Since two decades author and leadership consultant Frank Kanu helps top managers and executives to improve success ratios and productivity.
 About Frank Kanu  |  Testimonials  |  Order Books  |  Free Articles  |  Press  |  Excellence in Leadership  |  Genius One

Genius One Inc., Smart Solutions for Growth

Frank Uncovers Excellence in Leadership

Posts

Archive for the 'Code review' Category

Bad? - Answer

© Copyright Frank D. Kanu 2000-2008

The query was only getting bad because WHOEVER was messing with it didn’t READ ANY of the code around. That PLUS raping the original design to squeeze out something it was never intended to do instead of rethinking and designing something the “programmer” could be proud of…
Comment of the lead programmer

Does that need any further comment?




Related Postings:
  • Bad?
Tags:
original design  programmer
 Technorati (All Links are external): original design  programmer  code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Friday, January 18th, 2008 @ 14:19
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

Bad?

© Copyright Frank D. Kanu 2000-2008

How is this for a check-in reason:
“Mining always resets the query now. The query setup was getting bad and the core didn’t work with it.”


Related Postings:
  • Bad? - Answer
Tags:
check in  check in reason
 Technorati (All Links are external): check in  check in reason  code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Wednesday, January 16th, 2008 @ 19:50
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

No changes made

© Copyright Frank D. Kanu 2000-2008

I kid you not.
No changes made
This is the original check-in reason found in the version control system of commercial software with hundreds of user.

Just in case you were wondering, yes, there were changes…

Tags:
commercial software  version control system
 Technorati (All Links are external): commercial software  version control system  code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Friday, December 28th, 2007 @ 14:51
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

Do they ever test?

© Copyright Frank D. Kanu 2000-2008

The news are full of messages that Microsoft’s Windows Home Server corrupts files.
Then I learned today that MS outlook marks a low disk alert message as junk/spam:

Low Disk Space Alert on XXXX
Alert on XXXX at 12/xx/2007 12:01:33 AM
The following disk is low on free disk space. Low levels of free disk space can cause performance problems and prevent users from saving files on the disk.
Drive Letter: F:
Free Disk Space: 256.000000. MB
% Free Disk Space: 0.268364.%
You can disable this alert or change its threshold by using the Change Alert Notifications task in the Server Management Monitoring and Reporting taskpad.



The admin I know cursed worst than a sailor or a coachman. But maybe that was MS intention all along—to have folks curse and thus increase their work morale and output: those bad words can be very helpful at the workplace.

Two separate incidents, but both proof one thing: Testing always was and apparently always will be the forgotten stepchild of programming.

Can you share a story of an obviously untested program?

While that might be bothersome in some cases—once there are lives involved it is getting really messy.

How would you enforce more and better testing?

Maybe having the programmers / testers pay damages out of their own pocket?


Tags:
alert message  coachman  corrupts files  curse  damages  free disk space  home server  intention  junk  junk spam  low disk space  microsoft  monitoring and reporting  ms outlook  notifications  outlook  performance problems  programmers  proof  server management  spam  stepchild  test  testing  threshold  windows home server  work morale
 Technorati (All Links are external): alert message  coachman  corrupts files  curse  damages  free disk space  home server  intention  junk  junk spam  low disk space  microsoft  monitoring and reporting  ms outlook  notifications  outlook  performance problems  programmers  proof  server management  spam  stepchild  test  testing  threshold  windows home server  work morale  business  code review  it
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Friday, December 28th, 2007 @ 09:59
  • Filed under Business, Code review, IT

You can either add your thoughtful opinion to the other Responses.
You can follow responses to this entry through the RSS 2.0 feed.

No Thinking Involved - Answer

© Copyright Frank D. Kanu 2000-2008

This code was pasted all over the place.

Shouldn’t it have been declared and programmed once?

Despite what many think—copy and paste is not your friend. Why would anyone in their right set of mind want to include a parameter that is set to a specific value (not using a variable) but then check for a different value?

Tags:
copy and paste
 Technorati (All Links are external): copy and paste  code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Tuesday, October 9th, 2007 @ 10:00
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

No Thinking Involved

© Copyright Frank D. Kanu 2000-2008

...
  nId := GetIdFromDB;
  setSelectionPage(nId, '');

procedure setSelectionPage(id : integer; desc : String );
var
  myNode:TTreeNode;
begin
  bFilter := False;
  if (desc = '-1') then begin
    bFilter := True;
...


Tags:
Technorati (All Links are external): code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Monday, October 8th, 2007 @ 10:00
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

What does this do? - Answer

© Copyright Frank D. Kanu 2000-2008

As long as proper design and documentation aren’t part of the programmers work we can’t speak of engineering.

Btw, there was nobody neither admitting that code came from them nor being able to immediately explain what the code does…


Related Postings:
  • What does this do?
Tags:
programmers  proper design
 Technorati (All Links are external): programmers  proper design  code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Tuesday, September 25th, 2007 @ 10:00
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

What does this do?

© Copyright Frank D. Kanu 2000-2008

With 4 breaks and 3 counters and no documentation—you think anyone knows what it does?
for j := 0 to Items.Count - 1 do begin
  if ((TDataNode(Items[j].Data).NodeType = ntQ1) and (TDataNode(Items[j].Data).NodeID = Q1)) then begin
    k := j;
    Inc(k);
    while (k <= (Items.Count - 1)) do begin
      if (TDataNode(Items[k].Data).NodeType = ntQ1) then
        Break;
      if ((TDataNode(Items[k].Data).NodeType = ntQ2) and (TDataNode(Items[k].Data).NodeID = Q2)) then begin
        aNode := Items[k];
        m := k;
        Inc(m);
        while (m <= (FCurTV.Items.Count - 1)) do begin
          if (TDataNode(FCurTV.Items[m].Data).NodeType = ntQ2) then
            Break;
          if ((TDataNode(FCurTV.Items[m].Data).NodeType = ntQ3) and (TDataNode(FCurTV.Items[m].Data).NodeID = ID)) then begin
            bQ := TRUE;
            Break;
          end;
          Inc(m);
        end;
      end;
      Inc(k);
    end;
    Break;
  end;
end;


Tags:
documentation
 Technorati (All Links are external): documentation  code review
 
Digg  del.icio.us  StumbleUpon  Technorati  Reddit This blog-entry is protected by a digital fingerprint:785273ed81985582c8a1be62f78c9459
 
  • Frank Kanu on Monday, September 24th, 2007 @ 10:00
  • Filed under Code review

You can either add your thoughtful opinion
You can follow responses to this entry through the RSS 2.0 feed.

Archives and Links

You are on page 1 of 5

1 2345
  • Tags
    • blog
      change
      decisions
      e book
      education
      failure
      few days
      followers
      job
      kanu
      last time
      leader
      leaders
      leadership skills
      love
      mail
      manager
      managers
      mistakes
      money
      president bush
      programmers
      questions
      start leading
      stop telling

    • Tags sorted alphabetically
    • Tags sorted numerically
  • Categories
    • Business
      • Case Studies
      • Negotiations
    • Cooking
    • Definitions
    • Ethics
    • Events
    • Frank Kanu
    • General
      • Daily Question
      • Quote of the Day
      • Weekly Poll
    • IT
      • Code review
    • Leadership
    • Management
      • Teams
    • Motivation
    • Politics
    • Something funny
    • Stop Telling… Start Leading!
  • Random Posts
    • - German radio starts Klingon service
    • - 07/20/2007
    • - 11/01/2007

    • blogmap
    • More about Frank
  • Links
    • Frank Kanu's Books
    • - Andy Coote
    • - Andy Wibbels
    • - Billy McDermott*s Blog
    • - Blogcritics
    • - dandrea projetos
    • - David Intersimone “David I”
    • - Derek Jones
    • - Develop Your Vision
    • - enhance your leadership skills
    • - Forbes.com
    • - Frank Kanu
    • - Frank Kanu’s article archive
    • - Genius One
    • - Handelsblatt
    • - Karel’s Legal Blog
    • - Managing Leadership
    • - New York Nitty-Gritty
    • - News for nerds, stuff that matters
    • - Philip Greenspun’s Weblog
    • - Practical Developmental Ideas
    • - Practical Solutions to Business Puzzles
    • - Recipes
    • - Rick Cooper, The PDA Pro
    • - Roberta Pili
    • - Sacred Cow Dung
    • - Savvy Intrapreneur
    • - Scrapbooker for hire
    • - Scrapbooking 4 others
    • - seth godin’s blog
    • - stop telling… start leading!
    • - The Art of Managing People by Asking Questions
    • - The Washington Post
    • - TomPeters!
  • RSS Feed
    • Syndicate using RSS
    • The latest comments to all posts in RSS
  • Archives/Calendar
    • yearly archives
    • monthly archives
    • weekly archives
    • daily archives
    September 2008
    M T W T F S S
    « Aug    
    1234567
    891011121314
    15161718192021
    22232425262728
    2930  
  • Blog Of The Day Awards Winner

If not otherwise stated - all postings © Frank D. Kanu. All rights reserved.

This blog is designed to provide accurate and authoritative information in regard to the subject matter covered.
If legal advice or other expert assistance is required, the services of a competent professional should be sought.



Genius One Inc. · USA
Fax: (509) 463-0129 · E-mail:
info@GeniusOne.com

 


Privacy Statement   Sitemap

 
Copyright © 2000-2008 Genius One Inc.
All rights reserved.
Reproduction or use in whole or part in any form or medium without written permission of Genius One Inc. is prohibited.
If parts or any part of these WebPages is judicially determined to be invalid, that invalidity will not affect the remaining part of these Pages.